Various release-related improvements #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/release-improvements
branch
from
f49a2a2 to
24c64b7
Compare
This follows common practice of other projects and prevents surprises when people do: tar -xf oasis_core_<version>_linux_amd64.tar.gz and that extracts a bunch of files to the current directory instead of the oasis_core_<version>_linux_amd64 subdirectory.
Suffixing checksum files with the release's version allows multiple Oasis Core release tarballs and checksum files to co-exist in the same directory. Adding the '.txt' file extension to checksum files helps some web browsers figure out the file is a plain text document rather than an application/octet-stream.
tjanez
force-pushed
the
tjanez/release-improvements
branch
from
24c64b7 to
3273488
Compare
kostko
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3226.