Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txsource: Shut down nodes for longer period of time #3224

Merged
merged 1 commit into from
Sep 23, 2020
Merged

txsource: Shut down nodes for longer period of time #3224

merged 1 commit into from
Sep 23, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 31, 2020 •
edited
Loading

kostko
kostko reviewed Aug 31, 2020
View reviewed changes
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 11 times, most recently from 7c89149 to f4fa9f4 Compare August 31, 2020 14:40
@codecov
Copy link

codecov bot commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #3224 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   65.32%   65.22%   -0.10%     
==========================================
  Files         371      371              
  Lines       33043    33043              
==========================================
- Hits        21584    21553      -31     
- Misses       8278     8308      +30     
- Partials     3181     3182       +1
Impacted Files Coverage Δ
...ensus/tendermint/apps/staking/state/accumulator.go 62.06% <0.00%> (-10.35%) ⬇️
go/common/grpc/errors.go 79.06% <0.00%> (-9.31%) ⬇️
go/keymanager/client/client.go 81.41% <0.00%> (-6.20%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 75.00% <0.00%> (-5.00%) ⬇️
go/storage/mkvs/overlay.go 70.00% <0.00%> (-2.50%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 63.88% <0.00%> (-1.86%) ⬇️
go/worker/compute/executor/committee/node.go 60.22% <0.00%> (-1.75%) ⬇️
go/runtime/committee/nodes.go 69.69% <0.00%> (-1.52%) ⬇️
go/consensus/tendermint/roothash/roothash.go 70.76% <0.00%> (-1.24%) ⬇️
go/registry/api/api.go 41.87% <0.00%> (-1.09%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aaa29c...54043e9. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch from f4fa9f4 to 4e49ef5 Compare September 1, 2020 07:40
kostko
kostko reviewed Sep 1, 2020
View reviewed changes
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 13 times, most recently from 6800a6b to efddbcc Compare September 3, 2020 09:09
@ptrus ptrus marked this pull request as ready for review September 3, 2020 12:43
@ptrus ptrus requested a review from peterjgilbert as a code owner September 3, 2020 12:43
@ptrus ptrus requested a review from Yawning as a code owner September 3, 2020 12:43
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 2 times, most recently from b3ddc33 to 9c97df6 Compare September 3, 2020 14:05
kostko
kostko approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to revert the TODOs before merge.

.buildkite/longtests.pipeline.yml Outdated Show resolved Hide resolved
.buildkite/scripts/daily_txsource.sh Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/runtime.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime/txsource.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 9 times, most recently from 05d59d8 to d83b9d8 Compare September 11, 2020 13:16
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 10 times, most recently from aeb5675 to 48d5817 Compare September 18, 2020 16:59
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch 3 times, most recently from 2e00142 to 892c4f2 Compare September 22, 2020 15:49
@ptrus ptrus force-pushed the ptrus/feature/txsource-long-restarts branch from 892c4f2 to 54043e9 Compare September 23, 2020 06:59
@ptrus ptrus merged commit 51b83cb into master Sep 23, 2020
@ptrus ptrus deleted the ptrus/feature/txsource-long-restarts branch September 23, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

txsource: Shut down some nodes for longer period of time
2 participants
@ptrus @kostko