go/worker/executor: update scheduling parameters on runtime updates #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/scheduler-update-parameters
branch
from
0740aa0 to
b5bfd0c
Compare
kostko
approved these changes
Aug 28, 2020
| // XXX: Once there is more than one scheduling algorithm available | ||
| // this might need to recreate the scheduler and reinsert | ||
| // the transactions. | ||
| // At that point also udpate the schedulerMutex usage across the |
There was a problem hiding this comment.
Suggested change
| // At that point also udpate the schedulerMutex usage across the | |
| // At that point also update the schedulerMutex usage across the |
| Algorithm: "invalid", | ||
| }, | ||
| ) | ||
| require.Error(t, err, "UpdateParameters invalid udpate") | ||
|
|
| // Make sure transaction doesn't get scheduled. | ||
| err = scheduler.Flush(false) | ||
| require.NoError(t, err, "Flush(force=false)") | ||
| require.Equal(t, 1, scheduler.UnscheduledSize(), "transaction should remain scheduled after a non-forced flush") |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, 1, scheduler.UnscheduledSize(), "transaction should remain scheduled after a non-forced flush") | |
| require.Equal(t, 1, scheduler.UnscheduledSize(), "transaction should remain unscheduled after a non-forced flush") |
| @@ -14,7 +16,6 @@ const ( | |||
| ) | |||
|
|
|||
| type scheduler struct { | |||
| cfg config | |||
There was a problem hiding this comment.
Should we also remove the config type?
.changelog/3203.bugfix.md
Outdated
| @@ -0,0 +1,4 @@ | |||
| Executor scheduling doesn't refresh runtime parameters | |||
There was a problem hiding this comment.
Suggested change
| Executor scheduling doesn't refresh runtime parameters | |
| Executor should refresh runtime scheduling parameters |
ptrus
force-pushed
the
ptrus/feature/scheduler-update-parameters
branch
from
b5bfd0c to
45ca039
Compare
Codecov Report
@@ Coverage Diff @@
## master #3222 +/- ##
==========================================
- Coverage 67.47% 67.30% -0.18%
==========================================
Files 370 370
Lines 36323 36343 +20
==========================================
- Hits 24509 24460 -49
- Misses 8648 8703 +55
- Partials 3166 3180 +14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3203