Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node: Omit existing entity check for non-file signers #3216

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 27, 2020

Fixes #3215

The "registry entity init" subcommand previously always performed a check
whether an entity already exists. It did that by creating an additional signer
factory to perform this check.

Some signers assign exclusive access to an underlying resource (e.g., HSM) to
the given factory. In that case, all operations on the second signer factory
would fail. Thus we now omit the existing entity check for non-file signers.

The "registry entity init" subcommand previously always performed a check
whether an entity already exists. It did that by creating an additional signer
factory to perform this check.

Some signers assign exclusive access to an underlying resource (e.g., HSM) to
the given factory. In that case, all operations on the second signer factory
would fail. Thus we now omit the existing entity check for non-file signers.
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #3216 into master will increase coverage by 0.39%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3216      +/-   ##
==========================================
+ Coverage   67.38%   67.78%   +0.39%     
==========================================
  Files         370      370              
  Lines       36098    36101       +3     
==========================================
+ Hits        24326    24470     +144     
+ Misses       8628     8499     -129     
+ Partials     3144     3132      -12     
Impacted Files Coverage Δ
go/oasis-node/cmd/registry/entity/entity.go 45.96% <18.18%> (+0.25%) ⬆️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.28% <0.00%> (-10.04%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-4.25%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.03% <0.00%> (-3.45%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 66.17% <0.00%> (-1.48%) ⬇️
go/consensus/tendermint/roothash/roothash.go 72.31% <0.00%> (-0.85%) ⬇️
go/storage/api/root_cache.go 77.77% <0.00%> (ø)
go/worker/common/committee/node.go 75.70% <0.00%> (ø)
...o/consensus/tendermint/apps/staking/state/state.go 59.29% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2cccf...74a7bc1. Read the comment docs.

@kostko kostko merged commit 340ce3b into master Aug 27, 2020
@kostko kostko deleted the kostko/fix/cli-reg-entity-init branch August 27, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/registry/entity: Signer factory is not reused
3 participants