Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/roothash/tester: fix flaky RoundTimeoutWithEpochTransition #3214

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 26, 2020

Extracted from: #3212

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptrus ptrus force-pushed the ptrus/fix/roothash-test branch from 353057c to 7353236 Compare August 26, 2020 16:15
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #3214 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
+ Coverage   67.58%   67.69%   +0.10%     
==========================================
  Files         370      370              
  Lines       36098    36098              
==========================================
+ Hits        24398    24436      +38     
- Misses       8541     8550       +9     
+ Partials     3159     3112      -47     
Impacted Files Coverage Δ
go/roothash/tests/tester.go 89.72% <100.00%> (ø)
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/registry/api/grpc.go 36.08% <0.00%> (-7.34%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
go/worker/storage/service_external.go 51.47% <0.00%> (-5.89%) ⬇️
go/staking/api/grpc.go 54.26% <0.00%> (-5.04%) ⬇️
go/worker/keymanager/handler.go 60.37% <0.00%> (-3.78%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.03% <0.00%> (-3.45%) ⬇️
go/consensus/tendermint/staking/staking.go 57.45% <0.00%> (-3.32%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4db6a5...7353236. Read the comment docs.

@ptrus ptrus merged commit da2cccf into master Aug 26, 2020
@ptrus ptrus deleted the ptrus/fix/roothash-test branch August 26, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants