Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus: Move SubmitEvidence to LightClientBackend #3170

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 5, 2020

Fixes #3169

This allows light clients to submit evidence of Byzantine behavior.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #3170 into master will increase coverage by 0.13%.
The diff coverage is 57.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
+ Coverage   68.56%   68.70%   +0.13%     
==========================================
  Files         385      385              
  Lines       37873    37890      +17     
==========================================
+ Hits        25968    26031      +63     
+ Misses       8591     8532      -59     
- Partials     3314     3327      +13     
Impacted Files Coverage Δ
go/consensus/api/api.go 22.22% <ø> (-15.88%) ⬇️
go/consensus/api/base.go 2.77% <0.00%> (ø)
go/consensus/tendermint/light/client.go 46.34% <0.00%> (-3.23%) ⬇️
go/consensus/tendermint/full/full.go 64.99% <62.50%> (+1.26%) ⬆️
go/consensus/api/grpc.go 69.10% <71.42%> (+1.84%) ⬆️
go/consensus/tendermint/tests/evidence.go 92.72% <100.00%> (+0.57%) ⬆️
go/consensus/tests/tester.go 98.01% <100.00%> (+0.04%) ⬆️
go/worker/common/p2p/error/error.go 71.42% <0.00%> (-28.58%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/storage/metrics.go 78.26% <0.00%> (-6.53%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbc20b...e1456d5. Read the comment docs.

This allows light clients to submit evidence of Byzantine behavior.
@kostko kostko force-pushed the kostko/feature/consensus-submitevidence-move branch from ca06a8d to e1456d5 Compare August 5, 2020 08:51
@kostko kostko merged commit e147b73 into master Aug 5, 2020
@kostko kostko deleted the kostko/feature/consensus-submitevidence-move branch August 5, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move SubmitEvidence to LightClientBackend
2 participants