Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus: Add SubmitTxNoWait method #3153

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 31, 2020

Fixes #3152

The new method allows submitting a transaction without waiting for it to be
included in a block.

@kostko kostko force-pushed the kostko/feature/consensus-submitx-nowait branch 2 times, most recently from 6f8f7ee to a07ffb2 Compare July 31, 2020 08:55
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #3153 into master will decrease coverage by 0.23%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
- Coverage   68.75%   68.51%   -0.24%     
==========================================
  Files         383      383              
  Lines       37412    37438      +26     
==========================================
- Hits        25721    25651      -70     
- Misses       8414     8511      +97     
+ Partials     3277     3276       -1     
Impacted Files Coverage Δ
go/consensus/api/api.go 38.09% <ø> (ø)
go/consensus/api/base.go 2.77% <0.00%> (-0.08%) ⬇️
go/consensus/api/grpc.go 66.66% <71.42%> (-1.63%) ⬇️
go/consensus/tendermint/full/light.go 63.15% <100.00%> (+2.04%) ⬆️
go/consensus/tests/tester.go 97.97% <100.00%> (+0.17%) ⬆️
go/runtime/host/sandbox/sandbox.go 67.28% <0.00%> (-10.04%) ⬇️
go/consensus/tendermint/api/api.go 80.64% <0.00%> (-8.61%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 78.78% <0.00%> (-7.58%) ⬇️
go/worker/common/p2p/dispatch.go 71.96% <0.00%> (-7.48%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ce20a...997de78. Read the comment docs.

@kostko kostko marked this pull request as ready for review July 31, 2020 09:56
@Yawning
Copy link
Contributor

Yawning commented Jul 31, 2020

Do we need another call for this vs just adding an argument to the existing method?

@kostko
Copy link
Member Author

kostko commented Jul 31, 2020

Do we need another call for this vs just adding an argument to the existing method?

Yeah thought about that, but the blocking SubmitTx should only be available over the non-light interface (as it requires state and some more resources to track the transaction) and having a separate method makes it easier to split the two between interfaces.

The new method allows submitting a transaction without waiting for it to be
included in a block.
@kostko kostko force-pushed the kostko/feature/consensus-submitx-nowait branch from a07ffb2 to 997de78 Compare July 31, 2020 12:17
@kostko kostko merged commit 5086eea into master Jul 31, 2020
@kostko kostko deleted the kostko/feature/consensus-submitx-nowait branch July 31, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add non-blocking consensus SubmitTx variant
2 participants