Kill tests/fixture-data with fire
#3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
- Coverage 68.98% 68.82% -0.17%
==========================================
Files 375 376 +1
Lines 37060 37079 +19
==========================================
- Hits 25565 25518 -47
- Misses 8261 8330 +69
+ Partials 3234 3231 -3
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/3110
branch
2 times, most recently
from
8597ec3 to
2d2424d
Compare
3 tasks
Yawning
force-pushed
the
yawning/feature/3110
branch
5 times, most recently
from
9dc44ee to
6335ac8
Compare
Yawning
changed the title
tests/fixture-data with fire
Yawning
force-pushed
the
yawning/feature/3110
branch
4 times, most recently
from
456bebf to
9a25b44
Compare
Yawning
changed the title
tests/fixture-data with fire
Yawning
force-pushed
the
yawning/feature/3110
branch
from
9a25b44 to
2d151cb
Compare
kostko
reviewed
Jul 28, 2020
Yawning
force-pushed
the
yawning/feature/3110
branch
from
2d151cb to
f76491a
Compare
This should probably belong in another package for reuse by tests.
This is kind of pointless and is more annoying than actually testing anything since people just run the command to dump a new one and copy it when the test breaks.
Yawning
force-pushed
the
yawning/feature/3110
branch
from
2030b46 to
fd08527
Compare
kostko
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3110
Note: There still is random mystery accounts of doom, but now they all live in a single go file in the e2e test sub-directory. In an ideal world, these things will be derived properly, but to be honest, beyond the vague notion of "generated in a deterministic notion by something", I don't really have a good idea where they came from.