Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Tendermint consensus backend #3126

Merged
merged 4 commits into from
Jul 27, 2020
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 22, 2020

Fixes #3115
Fixes #3082

@kostko kostko force-pushed the kostko/feature/tm-cleanup branch from 27cc1e3 to 8405a88 Compare July 24, 2020 11:35
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #3126 into master will decrease coverage by 0.40%.
The diff coverage is 74.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3126      +/-   ##
==========================================
- Coverage   68.90%   68.49%   -0.41%     
==========================================
  Files         374      375       +1     
  Lines       37000    36996       -4     
==========================================
- Hits        25494    25340     -154     
- Misses       8269     8397     +128     
- Partials     3237     3259      +22     
Impacted Files Coverage Δ
go/consensus/api/api.go 50.00% <ø> (ø)
go/consensus/tendermint/abci/mux_mock.go 0.00% <0.00%> (ø)
go/consensus/tendermint/abci/state.go 68.02% <ø> (-1.37%) ⬇️
go/consensus/tendermint/api/api.go 80.64% <ø> (ø)
go/consensus/tendermint/tests/genesis/genesis.go 96.87% <ø> (ø)
.../consensus/tendermint/apps/roothash/state/state.go 68.62% <45.45%> (ø)
go/consensus/tendermint/beacon/beacon.go 55.00% <50.00%> (ø)
go/consensus/tendermint/keymanager/keymanager.go 78.84% <50.00%> (ø)
go/consensus/tendermint/scheduler/scheduler.go 67.10% <50.00%> (ø)
...sensus/tendermint/epochtime_mock/epochtime_mock.go 70.63% <60.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5464ad3...32893bf. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/tm-cleanup branch 2 times, most recently from 1777bb7 to 152bb01 Compare July 25, 2020 12:15
@kostko kostko marked this pull request as ready for review July 25, 2020 12:33
kostko added 4 commits July 27, 2020 13:22
All Tendermint configuration option names have been changed to be
consistently placed under `consensus.tendermint.`. This requires any previous
options that started with `tendermint.` to be changed to start with
`consensus.tendermint.`.
@kostko kostko force-pushed the kostko/feature/tm-cleanup branch from 152bb01 to 32893bf Compare July 27, 2020 11:23
@kostko kostko merged commit b269275 into master Jul 27, 2020
@kostko kostko deleted the kostko/feature/tm-cleanup branch July 27, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure TendermintService is only used internally Cleanup tendermint configuration options
2 participants