go/tests/e2e: add missing Clone() override to late-start

[ptrus]

Note: not overriding Clone in a scenario that embeds a different scenario actually causes embedded scenario test to be run (since Clone returns the embedded "parent" scenario).

Did check all other test scenarios and all do override the Clone() method.

[Yawning]

Is there a way to prevent this from happening in the future (that isn't "remove the Clone() thing as a bad idea")?

[codecov]

Codecov Report

Merging #3106 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   68.21%   68.01%   -0.20%     
==========================================
  Files         372      372              
  Lines       36896    36896              
==========================================
- Hits        25168    25095      -73     
- Misses       8459     8550      +91     
+ Partials     3269     3251      -18     

Impacted Files	Coverage Δ
go/oasis-node/cmd/ias/auth_registry.go	0.00% <0.00%> (-69.24%)	⬇️
...ompute/txnscheduler/algorithm/batching/batching.go	78.66% <0.00%> (-6.67%)	⬇️
go/registry/api/grpc.go	31.49% <0.00%> (-4.59%)	⬇️
go/consensus/tendermint/roothash/roothash.go	61.47% <0.00%> (-4.54%)	⬇️
go/oasis-node/cmd/keymanager/keymanager.go	48.88% <0.00%> (-1.95%)	⬇️
go/oasis-node/cmd/ias/proxy.go	51.47% <0.00%> (-0.74%)	⬇️
go/worker/common/committee/group.go	81.56% <0.00%> (-0.69%)	⬇️
go/storage/api/grpc.go	67.55% <0.00%> (-0.67%)	⬇️
go/worker/compute/txnscheduler/committee/node.go	64.86% <0.00%> (-0.31%)	⬇️
go/consensus/tendermint/tendermint.go	65.35% <0.00%> (-0.22%)	⬇️
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0466b12...aa2c14b. Read the comment docs.

[ptrus]

Is there a way to prevent this from happening in the future (that isn't "remove the Clone() thing as a bad idea")?

If we want to keep supporting the scenario flag combinations, we need it:

oasis-core/go/oasis-test-runner/cmd/root.go

Lines 107 to 110 in c56a606

	// parseTestParams parses --<test_name>.<key1>=<val1>,<val2>... flags combinations, clones provided proto-scenarios, and
	// populates them so that each scenario instance has unique parameter set. Returns mapping test name -> list of scenario
	// instances. NB: Golang maps are unordered so ordering of tests is *not preserved*.
	func parseTestParams(toRun []scenario.Scenario) (map[string][]scenario.Scenario, error) {

I didn't implement this, also it's not for me to decide, anyway i think we can open a separate issue to discuss this.