Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Add support for querying suspended runtimes #3099

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 10, 2020

Fixes: #3093

TODO:

  • fix the runtime_dynamic test
    • actually cannot reporduce this in the runtime dynamic test (or locally anymore), so it might have worked fine even before (even if the node fast-syncs it still get's all the events during fast syncing so it does get notified of the suspended runtimes). Nevertheless this change is still useful.

@ptrus ptrus force-pushed the ptrus/fix/runtimes-query-suspended branch from ab9baaa to 1fa59dc Compare July 10, 2020 09:07
go/oasis-node/cmd/registry/runtime/runtime.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/registry/runtime/runtime.go Outdated Show resolved Hide resolved
go/registry/tests/tester.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/fix/runtimes-query-suspended branch 2 times, most recently from d349102 to 1c3e2e7 Compare July 10, 2020 09:21
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #3099 into master will decrease coverage by 0.06%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3099      +/-   ##
==========================================
- Coverage   68.60%   68.53%   -0.07%     
==========================================
  Files         372      372              
  Lines       36896    36910      +14     
==========================================
- Hits        25312    25296      -16     
- Misses       8341     8351      +10     
- Partials     3243     3263      +20     
Impacted Files Coverage Δ
go/registry/api/api.go 41.45% <ø> (ø)
go/registry/api/grpc.go 43.42% <57.14%> (ø)
go/consensus/tendermint/apps/registry/query.go 82.60% <100.00%> (+0.79%) ⬆️
go/consensus/tendermint/registry/registry.go 76.11% <100.00%> (ø)
go/oasis-node/cmd/registry/runtime/runtime.go 59.71% <100.00%> (+0.71%) ⬆️
go/registry/tests/tester.go 91.64% <100.00%> (+0.05%) ⬆️
go/worker/compute/executor/committee/batch.go 69.23% <0.00%> (-15.39%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/worker/common/p2p/dispatch.go 67.28% <0.00%> (-7.48%) ⬇️
go/storage/metrics.go 75.00% <0.00%> (-6.53%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d5d65...92dac24. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/runtimes-query-suspended branch 2 times, most recently from 1dcc052 to 3dc0220 Compare July 13, 2020 14:16
@ptrus ptrus marked this pull request as ready for review July 13, 2020 14:16
@ptrus ptrus requested a review from kostko July 13, 2020 14:16
@ptrus ptrus force-pushed the ptrus/fix/runtimes-query-suspended branch 2 times, most recently from 1c5ef07 to a5cd79e Compare July 15, 2020 07:48
@ptrus ptrus force-pushed the ptrus/fix/runtimes-query-suspended branch from a5cd79e to 92dac24 Compare July 15, 2020 11:26
@ptrus ptrus merged commit 3263a4d into master Jul 15, 2020
@ptrus ptrus deleted the ptrus/fix/runtimes-query-suspended branch July 15, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node's runtime watcher should include suspended runtimes
3 participants