Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind to bump protocol versions before release #3098

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 10, 2020

Fixes #3097

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #3098 into master will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   68.31%   67.93%   -0.38%     
==========================================
  Files         372      372              
  Lines       36823    36833      +10     
==========================================
- Hits        25156    25024     -132     
- Misses       8421     8576     +155     
+ Partials     3246     3233      -13     
Impacted Files Coverage Δ
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-44.12%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 62.92% <0.00%> (-6.75%) ⬇️
go/oasis-node/cmd/keymanager/keymanager.go 45.55% <0.00%> (-5.28%) ⬇️
go/consensus/tendermint/keymanager/keymanager.go 81.92% <0.00%> (-4.82%) ⬇️
go/registry/api/grpc.go 31.49% <0.00%> (-4.59%) ⬇️
go/consensus/tendermint/roothash/roothash.go 61.47% <0.00%> (-4.54%) ⬇️
go/worker/keymanager/handler.go 60.37% <0.00%> (-3.78%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56a606...5f58fed. Read the comment docs.

@kostko kostko requested a review from tjanez July 10, 2020 08:45
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, i always forget this in PRs

@kostko kostko removed the request for review from tjanez July 10, 2020 09:15
@kostko kostko force-pushed the kostko/feature/release-proto-versions branch from 68515f4 to 5f58fed Compare July 10, 2020 13:03
@kostko kostko merged commit 0764b4a into master Jul 10, 2020
@kostko kostko deleted the kostko/feature/release-proto-versions branch July 10, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release process to make sure that protocol versions get bumped
3 participants