Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round sync metrics to storage worker #3089

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Jul 8, 2020

Closes #3088

@jberci jberci force-pushed the jberci/feature/metrics branch from 38735a0 to 374e84d Compare July 8, 2020 10:45
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #3089 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   68.41%   68.58%   +0.16%     
==========================================
  Files         372      372              
  Lines       36823    36833      +10     
==========================================
+ Hits        25193    25262      +69     
+ Misses       8377     8329      -48     
+ Partials     3253     3242      -11     
Impacted Files Coverage Δ
go/worker/storage/committee/node.go 70.32% <100.00%> (+0.65%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/worker/compute/executor/committee/state.go 85.18% <0.00%> (-14.82%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 78.66% <0.00%> (-6.67%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/storage/metrics.go 75.00% <0.00%> (-3.27%) ⬇️
go/consensus/api/grpc.go 65.85% <0.00%> (-2.44%) ⬇️
go/storage/api/root_cache.go 72.41% <0.00%> (-2.30%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0708e86...713d77f. Read the comment docs.

@jberci jberci force-pushed the jberci/feature/metrics branch from 374e84d to 844e319 Compare July 8, 2020 11:47
@jberci jberci marked this pull request as ready for review July 8, 2020 11:49
go/worker/storage/committee/node.go Show resolved Hide resolved
go/worker/storage/committee/node.go Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/metrics branch 3 times, most recently from bb515dc to b3ac812 Compare July 9, 2020 09:22
@jberci jberci force-pushed the jberci/feature/metrics branch from b3ac812 to 713d77f Compare July 9, 2020 15:30
@jberci jberci merged commit d52975a into master Jul 9, 2020
@jberci jberci deleted the jberci/feature/metrics branch July 9, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage worker sync metrics
2 participants