Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus: Expose read-only state via light client interface #3078

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 1, 2020

Fixes #3077

Nodes configured as consensus RPC services workers now expose read-only
access to consensus state via the usual MKVS ReadSyncer interface, allowing
light clients to remotely query state while transparently verifying proofs.

TODO

  • Expose syncer.ReadSyncer interface into consensus state over the light client interface.
  • Tests.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #3078 into master will decrease coverage by 0.09%.
The diff coverage is 78.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3078      +/-   ##
==========================================
- Coverage   68.58%   68.48%   -0.10%     
==========================================
  Files         372      372              
  Lines       36646    36734      +88     
==========================================
+ Hits        25133    25158      +25     
- Misses       8278     8329      +51     
- Partials     3235     3247      +12     
Impacted Files Coverage Δ
go/consensus/api/api.go 50.00% <ø> (ø)
go/consensus/api/grpc.go 65.85% <66.03%> (+0.03%) ⬆️
go/consensus/tendermint/api/api.go 75.75% <83.33%> (+1.21%) ⬆️
go/consensus/tendermint/abci/mux.go 72.81% <100.00%> (-1.16%) ⬇️
go/consensus/tendermint/full.go 61.11% <100.00%> (+2.28%) ⬆️
go/consensus/tendermint/tendermint.go 65.13% <100.00%> (+0.25%) ⬆️
go/consensus/tests/tester.go 97.80% <100.00%> (+0.65%) ⬆️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/consensus/tendermint/apps/roothash/query.go 68.42% <0.00%> (-10.53%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 451b663...a4fae15. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/consensus-state-readsyncer branch from 033b84a to 5739133 Compare July 1, 2020 15:01
@kostko kostko marked this pull request as ready for review July 1, 2020 15:01
@kostko kostko force-pushed the kostko/feature/consensus-state-readsyncer branch 2 times, most recently from b98ccd5 to 9a04dfe Compare July 1, 2020 15:57
@kostko kostko force-pushed the kostko/feature/consensus-state-readsyncer branch from 9a04dfe to 4403e23 Compare July 8, 2020 11:16
Nodes configured as consensus RPC services workers now expose read-only
access to consensus state via the usual MKVS ReadSyncer interface, allowing
light clients to remotely query state while transparently verifying proofs.
@kostko kostko force-pushed the kostko/feature/consensus-state-readsyncer branch from 4403e23 to a4fae15 Compare July 8, 2020 11:50
@kostko kostko merged commit 0fd92a9 into master Jul 8, 2020
@kostko kostko deleted the kostko/feature/consensus-state-readsyncer branch July 8, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consensus light client interface should expose read-only state
2 participants