Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/cbor: Reject CBOR blobs with unknown fields #3046

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 24, 2020

Fixes #2020

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #3046 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3046      +/-   ##
==========================================
- Coverage   68.67%   68.66%   -0.01%     
==========================================
  Files         370      370              
  Lines       36401    36401              
==========================================
- Hits        24997    24995       -2     
- Misses       8211     8225      +14     
+ Partials     3193     3181      -12     
Impacted Files Coverage Δ
go/common/cbor/cbor.go 59.37% <ø> (ø)
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 77.58% <0.00%> (-6.90%) ⬇️
go/consensus/tendermint/abci/mux.go 68.43% <0.00%> (-5.53%) ⬇️
go/registry/api/grpc.go 35.16% <0.00%> (-4.90%) ⬇️
go/staking/api/grpc.go 54.06% <0.00%> (-4.66%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-2.73%) ⬇️
go/consensus/tendermint/staking/staking.go 64.54% <0.00%> (-2.40%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dba6d1...f97a24c. Read the comment docs.

@Yawning Yawning force-pushed the yawning/fix/2020 branch from bc13cf1 to 010043c Compare June 24, 2020 13:40
@Yawning Yawning marked this pull request as ready for review June 24, 2020 13:40
@Yawning Yawning force-pushed the yawning/fix/2020 branch from 010043c to f97a24c Compare June 24, 2020 14:36
@Yawning Yawning merged commit a0330cc into master Jun 24, 2020
@Yawning Yawning deleted the yawning/fix/2020 branch June 24, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBOR deserialization is not strict
2 participants