Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Add MinWriteReplication to runtime storage parameters #3021

Merged
merged 5 commits into from
Jun 19, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 17, 2020

Fixes #1821

TODO

  • Commitment pool tests.
  • Registry tests.
  • Update storage client to only wait for MinWriteReplication writes.

@kostko kostko force-pushed the kostko/feature/storage-repl-factor branch 8 times, most recently from 3802778 to 241c521 Compare June 17, 2020 12:11
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #3021 into master will increase coverage by 0.16%.
The diff coverage is 78.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
+ Coverage   68.41%   68.57%   +0.16%     
==========================================
  Files         367      367              
  Lines       36143    36213      +70     
==========================================
+ Hits        24726    24834     +108     
+ Misses       8240     8193      -47     
- Partials     3177     3186       +9     
Impacted Files Coverage Δ
go/registry/api/runtime.go 49.47% <ø> (ø)
go/worker/compute/executor/committee/node.go 64.59% <46.66%> (-0.69%) ⬇️
go/runtime/registry/registry.go 73.49% <50.00%> (-2.67%) ⬇️
go/storage/init.go 82.97% <71.42%> (-0.36%) ⬇️
go/storage/client/client.go 76.17% <80.00%> (-0.93%) ⬇️
go/worker/storage/committee/node.go 70.26% <93.33%> (-2.88%) ⬇️
go/oasis-node/cmd/registry/runtime/runtime.go 58.99% <100.00%> (+0.24%) ⬆️
go/registry/api/api.go 41.65% <100.00%> (+1.19%) ⬆️
go/registry/tests/tester.go 91.68% <100.00%> (+0.08%) ⬆️
go/roothash/api/commitment/pool.go 73.78% <100.00%> (+4.40%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f731b92...352b4c7. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/storage-repl-factor branch 3 times, most recently from 86867c1 to a3c7660 Compare June 18, 2020 11:04
@kostko kostko marked this pull request as ready for review June 18, 2020 11:45
@kostko kostko force-pushed the kostko/feature/storage-repl-factor branch from 99f3c56 to 352b4c7 Compare June 19, 2020 09:39
@kostko kostko merged commit e39a3c6 into master Jun 19, 2020
@kostko kostko deleted the kostko/feature/storage-repl-factor branch June 19, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage/client: Only wait for F+1 successful writes
2 participants