Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI command for converting entities' ids to their staking account addresses #3009

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jun 12, 2020

Closes #3003.

@tjanez tjanez added c:staking Category: staking c:cli Category: command line interface labels Jun 12, 2020
.changelog/3003.feature.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #3009 into master will increase coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3009      +/-   ##
==========================================
+ Coverage   68.43%   68.45%   +0.02%     
==========================================
  Files         367      367              
  Lines       36073    36091      +18     
==========================================
+ Hits        24685    24706      +21     
+ Misses       8233     8228       -5     
- Partials     3155     3157       +2     
Impacted Files Coverage Δ
go/oasis-node/cmd/stake/stake.go 69.23% <44.44%> (-3.57%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
...ensus/tendermint/apps/staking/proposing_rewards.go 82.85% <0.00%> (-5.72%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/worker/common/p2p/p2p.go 61.71% <0.00%> (-4.51%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/worker/keymanager/handler.go 67.92% <0.00%> (-3.78%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a437ed0...56e8cb6. Read the comment docs.

.changelog/3003.feature.md Outdated Show resolved Hide resolved
go/oasis-node/cmd/stake/account.go Outdated Show resolved Hide resolved
@tjanez tjanez force-pushed the tjanez/cli-convert-entity-id-to-staking-address branch 3 times, most recently from a09178a to 0e9301a Compare June 15, 2020 11:01
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add E2E test to the stake_cli scenario, otherwise looks good!

@tjanez tjanez force-pushed the tjanez/cli-convert-entity-id-to-staking-address branch from 0e9301a to c1bf3eb Compare June 16, 2020 10:57
@tjanez
Copy link
Member Author

tjanez commented Jun 16, 2020

Add E2E test to the stake_cli scenario, otherwise looks good!

Done. Please, take another look.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tjanez tjanez force-pushed the tjanez/cli-convert-entity-id-to-staking-address branch from c1bf3eb to 56e8cb6 Compare June 16, 2020 13:36
@kostko kostko merged commit cc09c68 into master Jun 16, 2020
@kostko kostko deleted the tjanez/cli-convert-entity-id-to-staking-address branch June 16, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CLI command for converting entities' ids to their staking account addresses
2 participants