-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CLI command for converting entities' ids to their staking account addresses #3009
Add a CLI command for converting entities' ids to their staking account addresses #3009
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3009 +/- ##
==========================================
+ Coverage 68.43% 68.45% +0.02%
==========================================
Files 367 367
Lines 36073 36091 +18
==========================================
+ Hits 24685 24706 +21
+ Misses 8233 8228 -5
- Partials 3155 3157 +2
Continue to review full report at Codecov.
|
a09178a
to
0e9301a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add E2E test to the stake_cli
scenario, otherwise looks good!
0e9301a
to
c1bf3eb
Compare
Done. Please, take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
c1bf3eb
to
56e8cb6
Compare
Closes #3003.