Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/node: Log the version on startup #2998

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 10, 2020

Might as well, though it won't show up at the default log level.

Fixes #2663.

Might as well, though it won't show up at the default log level.
@Yawning Yawning force-pushed the yawning/feature/2663 branch from ea59be5 to 1146153 Compare June 10, 2020 12:18
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #2998 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   68.60%   68.54%   -0.06%     
==========================================
  Files         360      360              
  Lines       35379    35382       +3     
==========================================
- Hits        24270    24251      -19     
- Misses       7982     7999      +17     
- Partials     3127     3132       +5     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 58.70% <100.00%> (+2.86%) ⬆️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/storage/metrics.go 78.26% <0.00%> (-3.27%) ⬇️
go/worker/compute/executor/committee/node.go 62.57% <0.00%> (-2.69%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-2.30%) ⬇️
go/consensus/tendermint/abci/state.go 67.27% <0.00%> (-2.19%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.26% <0.00%> (-2.11%) ⬇️
go/storage/database/database.go 70.58% <0.00%> (-1.69%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffcef8...1146153. Read the comment docs.

@Yawning Yawning merged commit ce6ec47 into master Jun 10, 2020
@Yawning Yawning deleted the yawning/feature/2663 branch June 10, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit oasis-node version information in logs
2 participants