Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Don't panic on context cancellation #2982

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 5, 2020

No description provided.

@kostko kostko force-pushed the kostko/fix/tm-ctx-nopanic branch from 1d40815 to d8cfaa0 Compare June 5, 2020 09:09
@kostko kostko force-pushed the kostko/fix/tm-ctx-nopanic branch from d8cfaa0 to 47ba280 Compare June 5, 2020 09:22
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #2982 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
+ Coverage   68.47%   68.51%   +0.03%     
==========================================
  Files         360      360              
  Lines       35285    35285              
==========================================
+ Hits        24161    24174      +13     
+ Misses       8023     8013      -10     
+ Partials     3101     3098       -3     
Impacted Files Coverage Δ
go/consensus/tendermint/tendermint.go 64.18% <66.66%> (ø)
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/runtime/host/protocol/connection.go 61.53% <0.00%> (-3.85%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.76% <0.00%> (-2.11%) ⬇️
go/worker/compute/executor/committee/node.go 61.03% <0.00%> (-1.54%) ⬇️
go/runtime/client/client.go 72.26% <0.00%> (-1.46%) ⬇️
go/consensus/tendermint/abci/state.go 68.00% <0.00%> (-1.46%) ⬇️
go/storage/mkvs/iterator.go 84.37% <0.00%> (-1.25%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff6edc...47ba280. Read the comment docs.

Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, was this issue just lurking there all along?

@kostko kostko merged commit dc893d3 into master Jun 5, 2020
@kostko kostko deleted the kostko/fix/tm-ctx-nopanic branch June 5, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants