Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymanager: Rename APIs referencing "contracts" #2979

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jun 4, 2020

Each runtime does not neccecarily have a notion for contracts, so the
key manager now operates in terms of KeyPairIds that identify a given
KeyPair.

Fixes #2844.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #2979 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
- Coverage   68.57%   68.52%   -0.05%     
==========================================
  Files         360      360              
  Lines       35273    35273              
==========================================
- Hits        24188    24171      -17     
- Misses       7988     8000      +12     
- Partials     3097     3102       +5     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/storage/metrics.go 84.78% <0.00%> (-6.53%) ⬇️
go/consensus/tendermint/apps/registry/query.go 80.95% <0.00%> (-4.77%) ⬇️
go/storage/api/root_cache.go 72.41% <0.00%> (-4.60%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-4.09%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/database/database.go 72.26% <0.00%> (-3.37%) ⬇️
go/worker/compute/executor/committee/node.go 61.03% <0.00%> (-3.27%) ⬇️
go/consensus/tendermint/registry/registry.go 68.89% <0.00%> (-3.15%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdf2ec...261fa32. Read the comment docs.

Each runtime does not neccecarily have a notion for contracts, so the
key manager now operates in terms of `KeyPairId`s that identify a given
`KeyPair`.
@Yawning Yawning force-pushed the yawning/feature/2844 branch from 6dfa750 to 261fa32 Compare June 4, 2020 12:24
@Yawning Yawning merged commit fdbbbd1 into master Jun 4, 2020
@Yawning Yawning deleted the yawning/feature/2844 branch June 4, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make key manager API more generic
2 participants