-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automatically rebuild development/CI Docker images #2970
Conversation
8a334c1
to
fec912c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2970 +/- ##
==========================================
+ Coverage 68.41% 68.55% +0.13%
==========================================
Files 360 360
Lines 35273 35273
==========================================
+ Hits 24132 24180 +48
+ Misses 8033 7997 -36
+ Partials 3108 3096 -12
Continue to review full report at Codecov.
|
fec912c
to
30568b2
Compare
5255ef2
to
3bee11c
Compare
The Buildkite CI will fail as it needs a pipeline configuration change that will break all other jobs, so I haven't made it yet. Once approved I'll change Buildkite config and merge this. |
3bee11c
to
75bd931
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
# NOTE: This name appears in GitHub's Checks API and in workflow's status badge. | ||
name: docker | ||
|
||
# Trigger the workflow when: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this triggering configuration means that Docker images for stable/*
branches will only be built the first time a new stable/*
branch is pushed to GitHub and never again, unless there is a manual change to something in the docker/
directory.
In my opinion, this is fine for now, but perhaps file an issue so that we document this current limitation and perhaps address it in the future, if it will become a frequent issue or when GitHub Actions gain support for triggering workflows manually and we can just document how to do that when needed.
920e69b
to
9d52e54
Compare
Fixes #295