Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Automatically rebuild development/CI Docker images #2970

Merged
merged 3 commits into from
Jun 4, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 2, 2020

Fixes #295

@kostko kostko force-pushed the kostko/feature/ci-docker-images branch 2 times, most recently from 8a334c1 to fec912c Compare June 2, 2020 12:43
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2970 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2970      +/-   ##
==========================================
+ Coverage   68.41%   68.55%   +0.13%     
==========================================
  Files         360      360              
  Lines       35273    35273              
==========================================
+ Hits        24132    24180      +48     
+ Misses       8033     7997      -36     
+ Partials     3108     3096      -12     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/storage/mkvs/lookup.go 73.46% <0.00%> (-6.13%) ⬇️
go/consensus/tendermint/roothash/roothash.go 63.17% <0.00%> (-5.41%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 49.72% <0.00%> (-2.19%) ⬇️
go/worker/common/p2p/p2p.go 66.21% <0.00%> (-1.81%) ⬇️
go/consensus/tendermint/tendermint.go 63.88% <0.00%> (-0.72%) ⬇️
go/roothash/tests/tester.go 95.58% <0.00%> (-0.64%) ⬇️
go/roothash/api/commitment/pool.go 69.38% <0.00%> (-0.57%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 58.61% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a2bffe...9d52e54. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/ci-docker-images branch from fec912c to 30568b2 Compare June 2, 2020 13:23
.buildkite/pipeline.sh Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/ci-docker-images branch 3 times, most recently from 5255ef2 to 3bee11c Compare June 3, 2020 09:02
@kostko kostko marked this pull request as ready for review June 3, 2020 09:05
@kostko
Copy link
Member Author

kostko commented Jun 3, 2020

The Buildkite CI will fail as it needs a pipeline configuration change that will break all other jobs, so I haven't made it yet. Once approved I'll change Buildkite config and merge this.

.buildkite/longtests.pipeline.yml Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/ci-docker-images branch from 3bee11c to 75bd931 Compare June 3, 2020 10:13
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

# NOTE: This name appears in GitHub's Checks API and in workflow's status badge.
name: docker

# Trigger the workflow when:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this triggering configuration means that Docker images for stable/* branches will only be built the first time a new stable/* branch is pushed to GitHub and never again, unless there is a manual change to something in the docker/ directory.

In my opinion, this is fine for now, but perhaps file an issue so that we document this current limitation and perhaps address it in the future, if it will become a frequent issue or when GitHub Actions gain support for triggering workflows manually and we can just document how to do that when needed.

@kostko kostko force-pushed the kostko/feature/ci-docker-images branch from 920e69b to 9d52e54 Compare June 4, 2020 08:45
@kostko kostko merged commit a4e3761 into master Jun 4, 2020
@kostko kostko deleted the kostko/feature/ci-docker-images branch June 4, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regularly build docker image
3 participants