Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/sandbox: Retry Call in case the runtime is not yet ready #2967

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 2, 2020

Issue discovered in long-term tests.

@kostko kostko force-pushed the kostko/fix/executor-rt-retry branch from c3cec68 to eda25f5 Compare June 2, 2020 07:53
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2967 into master will decrease coverage by 0.18%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2967      +/-   ##
==========================================
- Coverage   68.62%   68.44%   -0.19%     
==========================================
  Files         360      360              
  Lines       35278    35273       -5     
==========================================
- Hits        24211    24144      -67     
- Misses       7971     8035      +64     
+ Partials     3096     3094       -2     
Impacted Files Coverage Δ
go/runtime/host/sandbox/sandbox.go 75.74% <84.61%> (-0.21%) ⬇️
go/worker/common/committee/runtime_host.go 65.71% <100.00%> (-3.26%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/worker/compute/executor/committee/node.go 61.03% <0.00%> (-6.53%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 82.97% <0.00%> (-4.26%) ⬇️
go/storage/mkvs/lookup.go 75.51% <0.00%> (-4.09%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.26% <0.00%> (-3.91%) ⬇️
go/runtime/host/protocol/connection.go 61.53% <0.00%> (-3.85%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 79.62% <0.00%> (-3.71%) ⬇️
go/storage/metrics.go 88.04% <0.00%> (-3.27%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e24dc8...a3b17a7. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/executor-rt-retry branch 2 times, most recently from 02e4ec8 to 228e76a Compare June 2, 2020 11:39
@kostko kostko force-pushed the kostko/fix/executor-rt-retry branch from 228e76a to 4c3aca7 Compare June 3, 2020 10:08
@kostko kostko force-pushed the kostko/fix/executor-rt-retry branch 2 times, most recently from 3ebebc7 to 24e3593 Compare June 3, 2020 12:34
@kostko kostko force-pushed the kostko/fix/executor-rt-retry branch from 24e3593 to a3b17a7 Compare June 3, 2020 15:54
@kostko kostko merged commit a06f799 into master Jun 3, 2020
@kostko kostko deleted the kostko/fix/executor-rt-retry branch June 3, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants