Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Drop support for v0 node descriptor #2963

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 1, 2020

Fixes #2918

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Jun 1, 2020
@kostko kostko force-pushed the kostko/feature/remove-v0-nodedsc branch from a49cadc to ffbe3e9 Compare June 1, 2020 15:38
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2963 into master will increase coverage by 0.17%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
+ Coverage   68.39%   68.57%   +0.17%     
==========================================
  Files         361      360       -1     
  Lines       35231    35178      -53     
==========================================
+ Hits        24095    24122      +27     
+ Misses       8028     7978      -50     
+ Partials     3108     3078      -30     
Impacted Files Coverage Δ
go/registry/api/api.go 40.24% <63.15%> (+0.82%) ⬆️
go/consensus/tendermint/api/api.go 74.54% <0.00%> (-14.55%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/storage/mkvs/remove.go 85.85% <0.00%> (-4.05%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 79.62% <0.00%> (-3.71%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.16% <0.00%> (-2.71%) ⬇️
go/consensus/tendermint/roothash/roothash.go 66.21% <0.00%> (-2.37%) ⬇️
go/common/node/node.go 69.10% <0.00%> (-1.63%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 69.09% <0.00%> (-1.56%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 63.70% <0.00%> (-1.49%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d490d3e...29eef08. Read the comment docs.

@kostko kostko marked this pull request as ready for review June 2, 2020 08:29
@kostko kostko force-pushed the kostko/feature/remove-v0-nodedsc branch from ffbe3e9 to 5f940f8 Compare June 2, 2020 15:08
@kostko kostko force-pushed the kostko/feature/remove-v0-nodedsc branch from 5f940f8 to 29eef08 Compare June 2, 2020 15:21
@kostko kostko merged commit d0a8e24 into master Jun 2, 2020
@kostko kostko deleted the kostko/feature/remove-v0-nodedsc branch June 2, 2020 15:50
tjanez added a commit that referenced this pull request Jun 9, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 9, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 9, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 10, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 10, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 11, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
tjanez added a commit that referenced this pull request Jun 11, 2020
The test scenario that used it was removed when support for v0 node
descriptor was removed in #2963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for node descriptor version 0
2 participants