Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notify runtimes of its key manager policy updates #2947

Merged
merged 1 commit into from
May 29, 2020
Merged

notify runtimes of its key manager policy updates #2947

merged 1 commit into from
May 29, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented May 27, 2020 •
edited
Loading

Fixes: #2919

This will also require (minor) changes to the oasis-runtime (updating the initalizer with the keymanager-update handle)

@ptrus ptrus force-pushed the ptrus/fix/km-policy-updates branch from 806f6d0 to f9fbf9c Compare May 27, 2020 13:31
kostko
kostko reviewed May 27, 2020
View reviewed changes
.changelog/2919.bugfix.md Outdated Show resolved Hide resolved
client/src/rpc/client.rs Outdated Show resolved Hide resolved
client/src/rpc/client.rs Outdated Show resolved Hide resolved
go/worker/common/runtime_host.go Outdated Show resolved Hide resolved
go/worker/common/committee/runtime_host.go Outdated Show resolved Hide resolved
keymanager-client/src/client.rs Outdated Show resolved Hide resolved
keymanager-client/src/client.rs Outdated Show resolved Hide resolved
keymanager-client/src/client.rs Outdated Show resolved Hide resolved
keymanager-client/src/client.rs Outdated Show resolved Hide resolved
runtime/src/dispatcher.rs Outdated Show resolved Hide resolved
kostko
kostko reviewed May 27, 2020
View reviewed changes
runtime/src/protocol.rs Outdated Show resolved Hide resolved
runtime/src/rpc/dispatcher.rs Outdated Show resolved Hide resolved
runtime/src/rpc/dispatcher.rs Outdated Show resolved Hide resolved
runtime/src/rpc/dispatcher.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/fix/km-policy-updates branch from f9fbf9c to 69a57ee Compare May 28, 2020 07:55
@codecov
Copy link

codecov bot commented May 28, 2020 •
edited
Loading

Codecov Report

Merging #2947 into master will increase coverage by 0.02%.
The diff coverage is 67.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2947      +/-   ##
==========================================
+ Coverage   68.54%   68.56%   +0.02%     
==========================================
  Files         361      361              
  Lines       35131    35191      +60     
==========================================
+ Hits        24080    24130      +50     
- Misses       7966     7979      +13     
+ Partials     3085     3082       -3
Impacted Files Coverage Δ
go/runtime/host/protocol/types.go 50.00% <ø> (ø)
go/worker/compute/executor/committee/node.go 64.29% <28.57%> (-4.25%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 63.36% <28.57%> (-0.86%) ⬇️
go/worker/common/runtime_host.go 68.75% <50.00%> (+2.08%) ⬆️
go/worker/keymanager/worker.go 67.37% <50.00%> (+1.42%) ⬆️
go/worker/common/committee/runtime_host.go 68.96% <78.46%> (+6.64%) ⬆️
go/runtime/host/protocol/connection.go 61.53% <100.00%> (-4.24%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8aaea0...74dc4ee. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/fix/km-policy-updates branch 5 times, most recently from 9878259 to 404994f Compare May 28, 2020 09:55
@ptrus ptrus marked this pull request as ready for review May 28, 2020 10:15
@ptrus ptrus force-pushed the ptrus/fix/km-policy-updates branch 2 times, most recently from cee27ab to 2e9ee3c Compare May 29, 2020 08:25
kostko
kostko approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, only a few minor comments otherwise this looks good!

keymanager-client/src/client.rs Outdated Show resolved Hide resolved
keymanager-client/src/client.rs Outdated Show resolved Hide resolved
runtime/src/rpc/dispatcher.rs Outdated Show resolved Hide resolved
tests/runtimes/simple-keyvalue/src/main.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/fix/km-policy-updates branch from 2e9ee3c to 74dc4ee Compare May 29, 2020 11:14
@ptrus ptrus merged commit 4bbe0c7 into master May 29, 2020
@ptrus ptrus deleted the ptrus/fix/km-policy-updates branch May 29, 2020 11:30
@ptrus ptrus mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notify runtimes of its key manager policy updates
2 participants
@ptrus @kostko