oasis-test-runner: Use explicit flagsets for scenario parameters

[matevz]

Fixes #2897

[codecov]

Codecov Report

Merging #2937 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
+ Coverage   68.48%   68.56%   +0.07%     
==========================================
  Files         361      361              
  Lines       35131    35131              
==========================================
+ Hits        24060    24086      +26     
+ Misses       7978     7970       -8     
+ Partials     3093     3075      -18     

Impacted Files	Coverage Δ
go/worker/compute/executor/committee/state.go	74.07% <0.00%> (-11.12%)	⬇️
go/common/grpc/policy/policy.go	64.38% <0.00%> (-6.85%)	⬇️
go/common/grpc/proxy/proxy.go	62.60% <0.00%> (-5.22%)	⬇️
go/storage/mkvs/tree.go	89.28% <0.00%> (-3.58%)	⬇️
go/worker/compute/executor/committee/node.go	61.55% <0.00%> (-3.31%)	⬇️
go/consensus/tendermint/roothash/roothash.go	66.21% <0.00%> (-2.37%)	⬇️
go/storage/api/root_cache.go	72.41% <0.00%> (-2.30%)	⬇️
go/storage/database/database.go	72.26% <0.00%> (-1.69%)	⬇️
go/storage/client/client.go	76.21% <0.00%> (-0.89%)	⬇️
go/roothash/tests/tester.go	95.58% <0.00%> (-0.64%)	⬇️
... and 23 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afb05f...f51636e. Read the comment docs.

[matevz]

Cloning scenario and its flagset is not as simple as I thought. Doing

newSc.flags =  flag.NewFlagSet(sc.name, flag.ContinueOnError)
newSc.flags.AddFlagSet(sc.flags)

keeps old references to values so the flagset is not correctly cloned. I will need to make separate helpers per scenario for copying the flags...

[matevz]

Cloning scenario and its flagset is not as simple as I thought. Doing

newSc.flags =  flag.NewFlagSet(sc.name, flag.ContinueOnError)
newSc.flags.AddFlagSet(sc.flags)

keeps old references to values so the flagset is not correctly cloned. I will need to make separate helpers per scenario for copying the flags...

This was now solved in d676397