Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staking: Add missing events #2935

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

abukosek
Copy link
Contributor

When testing the backported staking events for 20.6.1, kostko found a few events that I missed, so I added them in this PR.

@abukosek abukosek force-pushed the andrej/bugfix/more-staking-events branch 2 times, most recently from 5301dfa to ce56cbf Compare May 22, 2020 09:33
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #2935 into master will decrease coverage by 0.14%.
The diff coverage is 48.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
- Coverage   68.57%   68.42%   -0.15%     
==========================================
  Files         361      361              
  Lines       35086    35123      +37     
==========================================
- Hits        24060    24034      -26     
- Misses       7945     7998      +53     
- Partials     3081     3091      +10     
Impacted Files Coverage Δ
go/staking/api/sanity_check.go 49.15% <0.00%> (-0.85%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <14.28%> (-22.34%) ⬇️
...o/consensus/tendermint/apps/staking/state/state.go 58.64% <85.71%> (+0.36%) ⬆️
go/consensus/tendermint/abci/mux.go 69.81% <100.00%> (-0.17%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 45.98% <100.00%> (-1.46%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/consensus/tendermint/apps/roothash/query.go 68.42% <0.00%> (-10.53%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 68.62% <0.00%> (-3.93%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 407e098...655bfde. Read the comment docs.

@abukosek abukosek force-pushed the andrej/bugfix/more-staking-events branch 3 times, most recently from bf3cc38 to 35a4bef Compare May 22, 2020 11:11
@abukosek abukosek force-pushed the andrej/bugfix/more-staking-events branch 8 times, most recently from 70bd778 to 0a8af8b Compare May 22, 2020 13:32
@abukosek abukosek force-pushed the andrej/bugfix/more-staking-events branch from 0a8af8b to 655bfde Compare May 22, 2020 13:48
@abukosek abukosek merged commit 0df697c into master May 22, 2020
@abukosek abukosek deleted the andrej/bugfix/more-staking-events branch May 22, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants