-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/oasis-node: Add the debug dumpdb
command
#2921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2921 +/- ##
==========================================
+ Coverage 68.46% 68.49% +0.02%
==========================================
Files 360 360
Lines 34947 34994 +47
==========================================
+ Hits 23926 23968 +42
+ Misses 7941 7938 -3
- Partials 3080 3088 +8
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/2359
branch
8 times, most recently
from
May 20, 2020 15:46
86a0fa6
to
3d0a0ce
Compare
kostko
approved these changes
May 21, 2020
It is safer if tooling can access on-disk state of an offline node in a way that ensures that writes will be rejected. This adds support for doing so by rejecting writes at the API level and by configuring the backing database to open the DB for read-only access.
The dump tool was duplicating a considerable amount of this, so refactor it out into a helper to minimize code duplication.
The timekeeping part of this (needed for the registry) will be somewhat annoying to implement, and it's unfortunate that the ApplicationState is now split into two interfaces, but I can't think of a better way to do it, and this shouldn't be that bad even if we add more things.
Yawning
force-pushed
the
yawning/feature/2359
branch
4 times, most recently
from
May 21, 2020 12:59
a3dd9d1
to
a550fcc
Compare
This command will attempt to extract the ABCI state from a combination of a shutdown node's on-disk database and the genesis document currently being used by the network, and will write the output as a JSON formatted genesis document. Some caveats: - It is not guaranteed that the dumped output will be usable as an actual genesis document without manual intervention. - Only the state that would be exported via a normal dump from a running node will be present in the dump. - The epochtime base will be that of the original genesis document, and not the most recent epoch (different from a genesis dump).
Yawning
force-pushed
the
yawning/feature/2359
branch
from
May 21, 2020 14:03
a550fcc
to
00c0ed3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2359