-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/registry: Avoid storing full TLS certificates #2914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
added
s:blocked
Status: blocked on other work
c:breaking/consensus
Category: breaking consensus changes
c:breaking/cfg
Category: breaks configuration
and removed
s:blocked
Status: blocked on other work
labels
May 15, 2020
kostko
force-pushed
the
kostko/feature/reg-tls-keys
branch
6 times, most recently
from
May 19, 2020 08:27
75ae996
to
b2ee5dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2914 +/- ##
==========================================
+ Coverage 67.81% 68.38% +0.57%
==========================================
Files 358 360 +2
Lines 34909 34937 +28
==========================================
+ Hits 23673 23893 +220
+ Misses 8175 7965 -210
- Partials 3061 3079 +18
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/reg-tls-keys
branch
3 times, most recently
from
May 19, 2020 12:07
988c67b
to
944a023
Compare
Yawning
approved these changes
May 19, 2020
Previously the node registry descriptor contained full TLS certificates for talking with nodes via gRPC. This changes it so that only TLS public keys are used when verifying peer certificates for TLS authentication. This makes the registry descriptors smaller and also makes it easier to pass around TLS identities (as public keys are much shorter). Obviously, this change BREAKS the consensus protocol and all previously signed node descriptors.
kostko
force-pushed
the
kostko/feature/reg-tls-keys
branch
from
May 19, 2020 16:11
944a023
to
55086bf
Compare
kostko
force-pushed
the
kostko/feature/reg-tls-keys
branch
from
May 20, 2020 07:42
55086bf
to
0f8381b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c:breaking/cfg
Category: breaks configuration
c:breaking/consensus
Category: breaking consensus changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2556
Previously the node registry descriptor contained full TLS certificates for
talking with nodes via gRPC. This changes it so that only TLS public keys are
used when verifying peer certificates for TLS authentication.
This makes the registry descriptors smaller and also makes it easier to pass
around TLS identities (as public keys are much shorter).
Obviously, this change BREAKS the consensus protocol and all previously
signed node descriptors.
The following configuration changes are needed due to this change:
In
oasis-node registry node
CLI, the--node.committee_address
optionhas been renamed to
--node.tls_address
and the format has changed from<certificate>@ip:port
to<pubkey>@ip:port
.For configuring sentry nodes on the workers, the
--worker.sentry.cert_file
has been removed. Instead, the--worker.sentry.address
now takes the same address format as specifiedabove (
<pubkey>@ip:port
).Previously signed node descriptors (v0) are considered valid at genesis time
iff the node is exclusively a validator node as indicated by the role bits.
Other nodes will need to be removed from genesis.
TODO