runtime: Do SGX enclave signing ourself #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yawning
commented
May 7, 2020
•
Yawning
commented
- Add the ability to generate signed SIGSTRUCTs, without using the fortanix SGX SDK.
- Generate and pass the signature to the runtime loader (with a mock key for now).
Codecov Report
@@ Coverage Diff @@
## master #2893 +/- ##
==========================================
- Coverage 68.16% 67.98% -0.18%
==========================================
Files 354 357 +3
Lines 34347 34597 +250
==========================================
+ Hits 23411 23521 +110
- Misses 7961 8056 +95
- Partials 2975 3020 +45
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/sgx-sigstruct
branch
from
cb1c995 to
d794d8f
Compare
Yawning
changed the title
Yawning
force-pushed
the
yawning/feature/sgx-sigstruct
branch
6 times, most recently
from
b33c331 to
029e714
Compare
kostko
approved these changes
May 13, 2020
kostko
reviewed
May 13, 2020
This structure has mountains of brain damage including but not limited to: * 1 BCD encoded date. * 4 little endian(!) 3072 bit big ints. * 2 pre-computed big ints, because terrorizing developers is preferable to fully implementing RSA.
This was only used for IAS, but now that SIGSTRUCT generation is a thing, it's better in the common sgx package.
* The private key is now included, and accessible with enough flags. * The MRSIGNER now lives in the sgx package instead of the IAS one. There's nothing stopping us from generating yet another key for this and using the new key as the oasis test key, but there's also no compelling reason that I can see to do so.
Instead of using the Fortanix SGX runtime's dummy signer, a new argument `--signature` is added for sgxs enclaves, for the purpose of specifying the path to a pre-generated SIGSTRUCT.
Being able to verify these is also probably useful.
For now this will just generate one, signed with the same key that `runtime-loader` used to use (the Fortanix dummy key), but this will also support using file backed signatures, once we have an idea on how we are going to handle the process for such things.
Yawning
force-pushed
the
yawning/feature/sgx-sigstruct
branch
from
0c10cb2 to
2a90ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.