Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Bump tendermint to v0.33.3-oasis #2839

Merged
merged 2 commits into from
Apr 14, 2020
Merged

go: Bump tendermint to v0.33.3-oasis #2839

merged 2 commits into from
Apr 14, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Apr 13, 2020 •
edited
Loading

  • Bump the tendermint dependency to the fork based on v0.33.3
  • Fix oasis-core
  • Fix the random tool in extra that also broke (untested)
  • Max evidence age is now both block and time based. Support configuring the latter
  • Use the actual tendermint fork tag once @kostko makes one.
  • Add one of those changelog fragments.

Fixes #2834

@Yawning Yawning added c:consensus/cometbft Category: CometBFT c:breaking/consensus Category: breaking consensus changes labels Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #2839 into master will increase coverage by 0.04%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2839      +/-   ##
==========================================
+ Coverage   67.37%   67.41%   +0.04%     
==========================================
  Files         344      344              
  Lines       33071    33089      +18     
==========================================
+ Hits        22280    22306      +26     
+ Misses       7910     7907       -3     
+ Partials     2881     2876       -5
Impacted Files Coverage Δ
go/consensus/genesis/genesis.go 50.00% <ø> (ø)
go/consensus/tendermint/crypto/priv_val.go 48.83% <0.00%> (ø)
...o/oasis-node/cmd/identity/tendermint/tendermint.go 58.06% <0.00%> (ø)
go/consensus/tendermint/db/badger/badger.go 70.84% <77.77%> (+3.79%) ⬆️
go/consensus/tendermint/seed.go 70.00% <87.50%> (ø)
go/consensus/tendermint/api/api.go 73.58% <100.00%> (-15.10%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <100.00%> (+3.37%) ⬆️
go/consensus/tendermint/tendermint.go 66.71% <100.00%> (-0.92%) ⬇️
go/consensus/tendermint/tests/evidence.go 95.74% <100.00%> (+0.18%) ⬆️
go/oasis-node/cmd/genesis/genesis.go 53.05% <100.00%> (+0.22%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb76f1...953dc0d. Read the comment docs.

@kostko
Copy link
Member

kostko commented Apr 13, 2020

Use the actual tendermint fork tag once @kostko makes one.

The tag v0.33.3-oasis1 is now there.

@Yawning Yawning force-pushed the yawning/feature/tendermint-0.33 branch 2 times, most recently from 0d33407 to 1b03f06 Compare April 13, 2020 16:11
@kostko kostko requested a review from ptrus April 13, 2020 16:21
@Yawning
go: Bump tendermint to v0.33.3-oasis1
90c5833 
This is breaking as the tendermint block format has changed.
@Yawning Yawning force-pushed the yawning/feature/tendermint-0.33 branch 3 times, most recently from 4d80234 to 8e8ea8c Compare April 14, 2020 07:53
@Yawning
go/consensus/genesis: Make max evidence age block and time based
953dc0d 
 * Rename `max_evidence_age` -> `max_evidence_age_blocks`
 * Add `max_evidence_age_time` (default 48h)

This is obviously breaking.
@Yawning Yawning force-pushed the yawning/feature/tendermint-0.33 branch from 8e8ea8c to 953dc0d Compare April 14, 2020 08:02
@Yawning Yawning merged commit 10f9623 into master Apr 14, 2020
@Yawning Yawning deleted the yawning/feature/tendermint-0.33 branch April 14, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
c:breaking/consensus Category: breaking consensus changes c:consensus/cometbft Category: CometBFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Tendermint Core to 0.33.x
3 participants
@Yawning @kostko @ptrus