Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage/mkvs/urkel to just storage/mkvs #2792

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 27, 2020

Fixes #2657

The MKVS implementation has been changed from the initial "Urkel tree" structure
and it is no longer an actual "Urkel tree" so having "urkel" in its name is just
confusing.

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #2792 into master will decrease coverage by 0.58%.
The diff coverage is 56.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   62.62%   62.04%   -0.59%     
==========================================
  Files         389      386       -3     
  Lines       37157    37095      -62     
==========================================
- Hits        23271    23016     -255     
- Misses      10924    11055     +131     
- Partials     2962     3024      +62     
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/byzantine/storage.go 64.51% <ø> (ø)
go/oasis-node/cmd/debug/storage/storage.go 45.08% <ø> (-3.47%) ⬇️
go/oasis-node/cmd/storage/benchmark/benchmark.go 3.92% <ø> (ø)
go/runtime/registry/storage_router.go 65.00% <ø> (ø)
go/storage/api/api.go 76.00% <ø> (ø)
go/storage/api/grpc.go 70.56% <ø> (+0.66%) ⬆️
go/storage/client/client.go 78.00% <ø> (ø)
go/storage/database/database.go 77.27% <ø> (-1.82%) ⬇️
go/storage/metrics.go 84.78% <ø> (-3.27%) ⬇️
go/storage/mkvs/cache.go 62.97% <0.00%> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee3f42...005c580. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, as long as we don't have other implementations in the future

The MKVS implementation has been changed from the initial "Urkel tree" structure
and it is no longer an actual "Urkel tree" so having "urkel" in its name is just
confusing.
@kostko kostko force-pushed the kostko/feature/mkvs-reorg-dirs branch from f7369f2 to 005c580 Compare March 28, 2020 20:53
@kostko kostko merged commit b27c1cf into master Mar 28, 2020
@kostko kostko deleted the kostko/feature/mkvs-reorg-dirs branch March 28, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move storage/mkvs/urkel to just storage/mkvs
2 participants