Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Use our notion of latest height #2786

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 26, 2020

Do not let Tendermint determine the latest height as that completely ignores
ABCI processing so it can return a block for which local state does not yet
exist.

@kostko kostko force-pushed the kostko/fix/consensus-getblock-latest branch from 5e8473c to 6035f8e Compare March 26, 2020 13:03
@kostko kostko requested a review from ptrus March 26, 2020 13:05
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2786 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2786      +/-   ##
==========================================
+ Coverage   62.88%   63.06%   +0.18%     
==========================================
  Files         389      389              
  Lines       37084    37088       +4     
==========================================
+ Hits        23321    23391      +70     
+ Misses      10789    10706      -83     
- Partials     2974     2991      +17     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 73.06% <100.00%> (+0.12%) ⬆️
go/consensus/tendermint/tendermint.go 67.98% <100.00%> (-0.19%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-2.18%) ⬇️
go/worker/storage/committee/checkpointer.go 66.37% <0.00%> (-1.77%) ⬇️
go/storage/mkvs/urkel/iterator.go 84.37% <0.00%> (-1.25%) ⬇️
go/storage/client/client.go 76.76% <0.00%> (-1.25%) ⬇️
go/runtime/transaction/transaction.go 75.90% <0.00%> (-1.21%) ⬇️
go/worker/compute/merge/committee/node.go 75.87% <0.00%> (-0.25%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7609e69...50d87ba. Read the comment docs.

Do not let Tendermint determine the latest height as that completely ignores
ABCI processing so it can return a block for which local state does not yet
exist.
@kostko kostko force-pushed the kostko/fix/consensus-getblock-latest branch from 5c0a994 to 50d87ba Compare March 26, 2020 13:39
@kostko kostko merged commit b4546d5 into master Mar 26, 2020
@kostko kostko deleted the kostko/fix/consensus-getblock-latest branch March 26, 2020 14:12
@pro-wh
Copy link
Contributor

pro-wh commented Mar 26, 2020

https://docs.tendermint.com/master/spec/abci/abci.html#query

Height (int64): The block height for which you want the query (default=0 returns data for the latest committed block). Note that this is the height of the block containing the application's Merkle root hash, which represents the state as it was after committing the block at Height-1

we'd be changing this part of tendermint's query semantics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants