-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/oasis-node/cmd/debug/consim: Initial import #2784
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2784 +/- ##
==========================================
+ Coverage 66.98% 67.19% +0.20%
==========================================
Files 342 343 +1
Lines 32968 32987 +19
==========================================
+ Hits 22084 22165 +81
+ Misses 8186 8129 -57
+ Partials 2698 2693 -5
Continue to review full report at Codecov.
|
19a591c
to
ad3c982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all looks okay. some overarching comments:
- nothing exercises this in CI, so it'll rot
- this doesn't exercise the full functionality of staking, which looks at commit info stuff. the current simulator leaves those fields blank
Yeah we should run this as part of the daily test pipeline (see |
555a472
to
cfc2057
Compare
At some point, this becomes an exercise in re-implementing tendermint.
Do you honestly thing this will ever do anything more than burn CI resources? I highly doubt that this codebase will catch anything. |
I don't see why this would catch anything more than what the existing long-term workload does, it will more probably catch less. But if we have it, we should at least run it somewhere, otherwise why have it at all? |
I'm talking about sending fake results of a commit, not actually running a decentralized fault tolerance protocol.
a short smoketest on CI, not a long workload like this is intended to do. it'll catch code changes that break this. |
ok this PR is gonna need a description |
cfc2057
to
6f791f9
Compare
4ae5402
to
b74a099
Compare
b74a099
to
c142422
Compare
While it's possible to use the pruner to try to prevent the ABCI induced disk usage from growing out of control, having to save/prune is rather slow, even when backed by tmpfs. Enabling this option will keep ABCI state in memory, dramatically speeding up cases where only the final dump is required, especially if a sensible configuration is used for the pruner.
c142422
to
6dee7c3
Compare
Just so this won't rot, I don't expect this to actually catch anything other than code changes that break consim (or require re-generating the genesis doc used for testing).
6dee7c3
to
0518095
Compare
No description provided.