Various fixes #2783
Merged
Various fixes #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/fix/lt-test-fixes
branch
2 times, most recently
from
4517d9b to
51a459d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2783 +/- ##
==========================================
- Coverage 63.13% 62.93% -0.20%
==========================================
Files 389 389
Lines 37062 37077 +15
==========================================
- Hits 23398 23336 -62
- Misses 10688 10774 +86
+ Partials 2976 2967 -9
Continue to review full report at Codecov.
|
Yawning
approved these changes
Mar 25, 2020
Previously if multiple transactions in the same block were returned as QueryTxs results, each transaction was queried independently, resulting in multiple round trips. Now we use GetTransactionMultiple to prefetch multiple transactions in a single round trip which should improve latency.
Previously the storage client did not refresh connections on each retry, so in case a committee change happened while an operation was in progress, all operations continued to use the old connection (which was closed) and thus failed. We now refresh connections on each retry.
kostko
force-pushed
the
kostko/fix/lt-test-fixes
branch
from
51a459d to
051c264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains fixes for issues discovered during long-term testing of #2674 which are also present in master.