-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txsource/queries: workload doing various queries #2769
Conversation
7b3f865
to
cf3e6cc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2769 +/- ##
==========================================
+ Coverage 62.74% 62.95% +0.21%
==========================================
Files 387 388 +1
Lines 36526 36828 +302
==========================================
+ Hits 22917 23185 +268
+ Misses 10708 10686 -22
- Partials 2901 2957 +56
Continue to review full report at Codecov.
|
a8882e6
to
07f39d2
Compare
weird, why did we even have both? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, are we testing these?
4d67e87
to
525bfad
Compare
@@ -0,0 +1,3 @@ | |||
go/staking: add LastBlockFees query method | |||
|
|||
LastBlockFees returns the collected fees for previous block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly unrelated, but this is also something that should be part of the genesis state dump as otherwise it could cause the total token amount to become inconsistent on dump/restore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh we don't do that at the moment :o will do a PR that adds that tomorrow 😁
525bfad
to
398f914
Compare
thanks for the reviews @pro-wh |
Queries workload, part of: #2506
Also removes(extracted out)GetNodeList()
client query as it's almost identical to theGetNodes
one (minus the sorting) and it's not used anywhere at the moment - can revert that commit if desired.LastBlockFees
query method to staking client, so that client is able to obtain all funds and confirm total supply matches correctlyFeel free to comment in case any relevant queries/checks should be added.
TODO: