Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/stake: Use stake.shares flag in gen_reclaim_escrow tx #2738

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Feb 27, 2020

Closes #2690.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #2738 into master will decrease coverage by 0.1%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
- Coverage   63.08%   62.98%   -0.11%     
==========================================
  Files         383      383              
  Lines       36094    36097       +3     
==========================================
- Hits        22770    22734      -36     
- Misses      10501    10503       +2     
- Partials     2823     2860      +37
Impacted Files Coverage Δ
go/oasis-node/cmd/stake/account.go 57.44% <81.81%> (+0.69%) ⬆️
go/worker/compute/executor/committee/state.go 74.07% <0%> (-11.12%) ⬇️
go/common/grpc/auth/auth.go 88.88% <0%> (-5.56%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-5.23%) ⬇️
go/consensus/api/grpc.go 59.3% <0%> (-4.66%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0%> (-4.35%) ⬇️
go/worker/compute/executor/committee/node.go 62% <0%> (-3.75%) ⬇️
go/worker/common/p2p/p2p.go 67.56% <0%> (-3.61%) ⬇️
go/storage/client/client.go 76.47% <0%> (-2.53%) ⬇️
go/runtime/transaction/transaction.go 75.9% <0%> (-2.41%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e4e99...90677b1. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a different CLI flag when specifying shares to reclaim from an escrow
2 participants