Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/cbor: Bump fxamacker/cbor to v2.2 #2729

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 26, 2020

Fixes #2635

@kostko kostko force-pushed the kostko/feature/bump-cbor-v2.2 branch from 9a32a07 to c5d9de0 Compare February 26, 2020 10:51
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #2729 into master will decrease coverage by 0.1%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
- Coverage   63.22%   63.11%   -0.11%     
==========================================
  Files         378      378              
  Lines       35532    35538       +6     
==========================================
- Hits        22464    22431      -33     
- Misses      10248    10285      +37     
- Partials     2820     2822       +2
Impacted Files Coverage Δ
go/common/grpc/service.go 56% <ø> (ø) ⬆️
go/common/cbor/cbor.go 61.53% <50%> (-8.47%) ⬇️
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
go/consensus/tendermint/api/api.go 73.58% <0%> (-15.1%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0%> (-9.01%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 84.61% <0%> (-5.13%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.34% <0%> (-2.17%) ⬇️
go/consensus/tendermint/tendermint.go 66.34% <0%> (-1.38%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.7% <0%> (-1.38%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d5a62...c5d9de0. Read the comment docs.

@kostko kostko merged commit 71aa7f2 into master Feb 26, 2020
@kostko kostko deleted the kostko/feature/bump-cbor-v2.2 branch February 26, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump fxamacker/cbor to 2.x
2 participants