go/oasis-node/txsource: add parallel workload #2724
Conversation
ptrus
requested review from
kostko,
peterjgilbert and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/txsource-parallel
branch
3 times, most recently
from
7e6a2cc to
366c2ff
Compare
ptrus
force-pushed
the
ptrus/feature/txsource-parallel
branch
from
366c2ff to
572761e
Compare
| return fmt.Errorf("workload parallel: error submiting transaction: %w", err) | ||
|
|
||
| case <-waitC: | ||
| parallelLogger.Debug("all transfers successfull", |
There was a problem hiding this comment.
| parallelLogger.Debug("all transfers successfull", | |
| parallelLogger.Debug("all transfers successful", |
| var err error | ||
| fac := memorySigner.NewFactory() | ||
| for i := range accounts { | ||
| accounts[i], err = fac.Generate(signature.SignerEntity, rng) |
There was a problem hiding this comment.
I assume these accounts don't need any balance as they don't include any fees? If (when) you need fees, you would need to make sure to include accounts in genesis (defined in the txsource E2E test).
An alternative way (to avoid having each workload to include new accounts in genesis for the default seed) would be to only have a single (known, seed-independent) account in genesis and txsource support for funding workloads on start (e.g., a simple API to transfer into arbitrary accounts before the workload main loop starts).
There was a problem hiding this comment.
Don't test networks include the test entity?
There was a problem hiding this comment.
yeah agreed and makes sense. Maybe it would be nicer if I do that in a separate PR though as it will also affect other workloads (at least the transfer one), and I can for now just keep Fees to zero here.
There was a problem hiding this comment.
Yeah definitely in a separate PR. Could use the test entity for this yeah 👍
| wg.Add(parallelConcurency) | ||
|
|
||
| for i := 0; i < parallelConcurency; i++ { | ||
|
|
ptrus
force-pushed
the
ptrus/feature/txsource-parallel
branch
from
572761e to
4c6f699
Compare
Codecov Report
@@ Coverage Diff @@
## master #2724 +/- ##
=========================================
+ Coverage 62.9% 63.21% +0.3%
=========================================
Files 382 379 -3
Lines 36036 35596 -440
=========================================
- Hits 22670 22501 -169
+ Misses 10502 10273 -229
+ Partials 2864 2822 -42
Continue to review full report at Codecov.
|
ptrus
force-pushed
the
ptrus/feature/txsource-parallel
branch
from
4c6f699 to
50605e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2724 +/- ##
=========================================
+ Coverage 62.9% 63.21% +0.3%
=========================================
Files 382 379 -3
Lines 36036 35596 -440
=========================================
- Hits 22670 22501 -169
+ Misses 10502 10273 -229
+ Partials 2864 2822 -42
Continue to review full report at Codecov.
|
Adds parallel txsource workload (part of: #2506)