Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Disable additional signature verification for migration #2656

Merged

Conversation

peterjgilbert
Copy link
Contributor

Some places were missed when signature verification was disabled for the
purpose of migration.

Some places were missed when signature verification was disabled for the
purpose of migration.
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #2656 into stable/20.3.x will decrease coverage by 0.05%.
The diff coverage is 31.57%.

Impacted file tree graph

@@                Coverage Diff                @@
##           stable/20.3.x    #2656      +/-   ##
=================================================
- Coverage          63.07%   63.02%   -0.06%     
=================================================
  Files                365      365              
  Lines              34386    34396      +10     
=================================================
- Hits               21690    21678      -12     
- Misses             10024    10039      +15     
- Partials            2672     2679       +7
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/fixgenesis/fixgenesis.go 8.53% <0%> (ø) ⬆️
go/consensus/tendermint/seed.go 70.65% <16.66%> (-2.08%) ⬇️
go/consensus/tendermint/tendermint.go 66.89% <37.5%> (-0.14%) ⬇️
go/registry/api/api.go 36.82% <50%> (ø) ⬆️
go/common/grpc/auth/auth.go 88.88% <0%> (-5.56%) ⬇️
go/worker/storage/service_external.go 47.19% <0%> (-4.5%) ⬇️
go/storage/mkvs/urkel/writelog/iterator.go 92.72% <0%> (-3.64%) ⬇️
go/runtime/history/prune.go 74.19% <0%> (-3.23%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-2.99%) ⬇️
go/storage/mkvs/urkel/db/api/helpers.go 64.78% <0%> (-2.82%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef985a5...5588fa9. Read the comment docs.

@peterjgilbert peterjgilbert requested a review from pro-wh February 7, 2020 19:37
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎵 transfer

@peterjgilbert peterjgilbert merged commit 2ef802e into stable/20.3.x Feb 7, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/stable/20.3.x/backport-2652 branch February 7, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants