Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Disable additional signature verification for migration #2652

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Feb 6, 2020

For the purpose of migration.

Predictably, disabling this sort of thing is error prone. :/

@Yawning Yawning added c:registry Category: entity/node/runtime registry service c:bug Category: bug c:security Category: security sensitive labels Feb 6, 2020
@Yawning Yawning self-assigned this Feb 6, 2020
@Yawning Yawning force-pushed the yawning/fix/disable-tls-check branch from 744d2bb to fc9e481 Compare February 6, 2020 20:46
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #2652 into master will decrease coverage by 0.02%.
The diff coverage is 31.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   62.92%   62.89%   -0.03%     
==========================================
  Files         365      365              
  Lines       34458    34468      +10     
==========================================
- Hits        21682    21679       -3     
- Misses      10077    10085       +8     
- Partials     2699     2704       +5
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/fixgenesis/fixgenesis.go 8.53% <0%> (ø) ⬆️
go/consensus/tendermint/seed.go 70.65% <16.66%> (-2.08%) ⬇️
go/consensus/tendermint/tendermint.go 66.07% <37.5%> (-0.97%) ⬇️
go/registry/api/api.go 36.82% <50%> (ø) ⬆️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/worker/storage/service_external.go 47.19% <0%> (-4.5%) ⬇️
go/worker/common/p2p/p2p.go 64.41% <0%> (-3.16%) ⬇️
go/worker/common/committee/group.go 79.33% <0%> (-0.67%) ⬇️
go/roothash/tests/tester.go 95.54% <0%> (-0.64%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09d964...3330d8f. Read the comment docs.

Some places were missed when signature verification was disabled for the
purpose of migration.
@Yawning Yawning force-pushed the yawning/fix/disable-tls-check branch from 689be7a to 3330d8f Compare February 7, 2020 11:10
@Yawning Yawning changed the title go/registry: Disable the TLS certificate check for old descriptors go: Disable additional signature verification for migration Feb 7, 2020
@Yawning Yawning merged commit f371f0d into master Feb 7, 2020
@Yawning Yawning deleted the yawning/fix/disable-tls-check branch February 7, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:registry Category: entity/node/runtime registry service c:security Category: security sensitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants