Optionally require a deposit for registering a runtime #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
4 times, most recently
from
6ed5b09 to
0c2b008
Compare
Codecov Report
@@ Coverage Diff @@
## master #2642 +/- ##
==========================================
- Coverage 62.99% 62.81% -0.19%
==========================================
Files 365 365
Lines 34424 34548 +124
==========================================
+ Hits 21686 21701 +15
- Misses 10035 10123 +88
- Partials 2703 2724 +21
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
2 times, most recently
from
22683ca to
645e736
Compare
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
2 times, most recently
from
ac97a62 to
ae52c3f
Compare
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
from
ae52c3f to
ce2ed43
Compare
|
Now also with dynamic runtime E2E tests. |
Yawning
reviewed
Feb 6, 2020
There was a problem hiding this comment.
So there's nothing "wrong" with this from a cursory look, but there is a question about how we want to handle entities that both register a runtime, and operate nodes, since the stake checks are distinct.
Hypothetically say the stake required to operate a node is 3, and the stake required to register a runtime is 2. An entity with a stake of 3 should be able to do one or the other, and not both.
|
Yeah, I think adding a stateful stake accumulator would be best to solve this in the general case.
|
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
3 times, most recently
from
38a705b to
81bf702
Compare
|
Added stateful stake accumulator, PTAL. |
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
from
81bf702 to
7b88617
Compare
Yawning
reviewed
Feb 10, 2020
Previously the EntityID was inferred from the signed runtime descriptor's envelope which was inconvenient. This changes the descriptor to be more in line with what we do for node descriptors. This also prevents entity deregistrations when an entity owns any runtimes.
Previously there was no central place to account for all the parts that need to claim some part of an entity's stake which required approximations all around. This is now changed and a stateful stake accumulator is added to each escrow account. The stake accumulator is used to track stake claims from different apps (currently only the registry). This change also means that node registration will now always require the correct amount of stake.
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
from
7b88617 to
ce00a2c
Compare
kostko
force-pushed
the
kostko/feature/rt-reg-stake
branch
from
ce00a2c to
810c887
Compare
Yawning
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2638
Also changes the runtime descriptor to include an explicit
EntityIDand adds a stateful stake accumulator.