Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint/apps/staking: Fix epochtime overflow #2631

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 31, 2020

Based on #2630
Fixes #2627

TODO

  • Add test for overflow in double signing evidence handler.
  • Fix overflow in double signing evidence handler.
  • Check if there are other places which overflow epochtime.

@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch from 8de0b2c to 895a6cc Compare January 31, 2020 12:12
@kostko kostko force-pushed the kostko/feature/tm-mock-appstate branch from 1e93546 to 62c8eeb Compare January 31, 2020 12:48
@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch from 895a6cc to 0dd5a3f Compare January 31, 2020 12:49
@kostko kostko marked this pull request as ready for review January 31, 2020 12:50
@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch 2 times, most recently from 4a369f1 to d5d82ed Compare January 31, 2020 13:10
@kostko kostko changed the base branch from kostko/feature/tm-mock-appstate to master January 31, 2020 13:15
@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch 2 times, most recently from a218ba6 to 9dc576e Compare January 31, 2020 14:28
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8b88a33). Click here to learn what that means.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2631   +/-   ##
=========================================
  Coverage          ?   63.05%           
=========================================
  Files             ?      360           
  Lines             ?    34142           
  Branches          ?        0           
=========================================
  Hits              ?    21529           
  Misses            ?     9953           
  Partials          ?     2660
Impacted Files Coverage Δ
go/consensus/tendermint/apps/registry/registry.go 64.35% <0%> (ø)
go/consensus/tendermint/apps/staking/staking.go 61.66% <0%> (ø)
go/consensus/tendermint/apps/staking/slashing.go 73.33% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b88a33...8b7ef7a. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch from 9dc576e to a68c035 Compare January 31, 2020 17:00
@kostko kostko force-pushed the kostko/fix/epochtime-overflow branch from a68c035 to 8b7ef7a Compare January 31, 2020 17:14
@kostko kostko merged commit 4e22a8a into master Jan 31, 2020
@kostko kostko deleted the kostko/fix/epochtime-overflow branch January 31, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check EpochTime math for overflow
2 participants