Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible key manager policy signers #2623

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Flexible key manager policy signers #2623

merged 1 commit into from
Jan 31, 2020

Conversation

abukosek
Copy link
Contributor

Closes #2444.

@abukosek abukosek force-pushed the andrej/feature/flexible-km-signers branch from 5dff1bb to beca1ed Compare January 31, 2020 06:55
@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@599affa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2623   +/-   ##
=========================================
  Coverage          ?   62.97%           
=========================================
  Files             ?      360           
  Lines             ?    34046           
  Branches          ?        0           
=========================================
  Hits              ?    21439           
  Misses            ?     9933           
  Partials          ?     2674

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599affa...16f2b3c. Read the comment docs.

kostko
kostko reviewed Jan 31, 2020
View reviewed changes
keymanager-api-common/src/api.rs Outdated Show resolved Hide resolved
keymanager-runtime/src/main.rs Show resolved Hide resolved
keymanager-runtime/api/src/api.rs Show resolved Hide resolved
@abukosek abukosek force-pushed the andrej/feature/flexible-km-signers branch from beca1ed to b721a60 Compare January 31, 2020 13:22
@abukosek abukosek force-pushed the andrej/feature/flexible-km-signers branch from b721a60 to 16f2b3c Compare January 31, 2020 13:22
@abukosek abukosek merged commit f26813f into master Jan 31, 2020
@abukosek abukosek deleted the andrej/feature/flexible-km-signers branch January 31, 2020 14:16
@abukosek
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flexible key manager policy signers
2 participants
@abukosek @kostko