Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Re-enable signature verification disabled for migration #2621

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jan 30, 2020

Now that the migration has hopefully been done, re-enable all of the
signature verification that was disabled for the sake of allowing for
migration.

Fixes #2615

@Yawning Yawning added c:registry Category: entity/node/runtime registry service c:bug Category: bug c:security Category: security sensitive labels Jan 30, 2020
@Yawning Yawning self-assigned this Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #2621 into master will increase coverage by 0.12%.
The diff coverage is 27.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
+ Coverage   62.82%   62.95%   +0.12%     
==========================================
  Files         365      365              
  Lines       34468    34424      -44     
==========================================
+ Hits        21653    21670      +17     
+ Misses      10139    10079      -60     
+ Partials     2676     2675       -1
Impacted Files Coverage Δ
go/consensus/tendermint/apps/registry/genesis.go 53.04% <ø> (+0.9%) ⬆️
go/consensus/tendermint/tendermint.go 67.31% <0%> (+1.51%) ⬆️
go/oasis-node/cmd/debug/fixgenesis/fixgenesis.go 10.29% <0%> (+1.75%) ⬆️
go/registry/api/sanity_check.go 61.86% <0%> (+2.66%) ⬆️
go/consensus/tendermint/seed.go 72.72% <0%> (+2.07%) ⬆️
go/registry/api/api.go 36.8% <31.42%> (-0.02%) ⬇️
...nsus/tendermint/apps/supplementarysanity/checks.go 50.45% <33.33%> (-1.47%) ⬇️
go/control/debug.go 67.74% <0%> (-6.46%) ⬇️
go/runtime/history/prune.go 74.19% <0%> (-3.23%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0%> (-2.63%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f371f0d...67eab84. Read the comment docs.

@Yawning
Copy link
Contributor Author

Yawning commented Jan 30, 2020

This should back out the horrific evil done in #2614, but it can't be merged till a release with said evil is made.

@Yawning Yawning force-pushed the yawning/fix/revert-2614 branch from 2a21ebd to d082ecb Compare February 7, 2020 11:12
Now that the migration has hopefully been done, re-enable all of the
signature verification that was disabled for the sake of allowing for
migration.
@Yawning Yawning force-pushed the yawning/fix/revert-2614 branch from d082ecb to 67eab84 Compare February 7, 2020 11:45
@Yawning Yawning changed the title go/registry: Re-enable signature verification in InitChain go: Re-enable signature verification disabled for migration Feb 7, 2020
@Yawning Yawning marked this pull request as ready for review February 7, 2020 17:14
@Yawning Yawning merged commit 339797f into master Feb 7, 2020
@Yawning Yawning deleted the yawning/fix/revert-2614 branch February 7, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:registry Category: entity/node/runtime registry service c:security Category: security sensitive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go/registry: Revert most of #2614
2 participants