Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/storage: Add configurable limits for storage operations #2618

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 30, 2020

Fixes #1914

@kostko kostko force-pushed the kostko/feature/storage-limits branch from a2d6bf8 to a221d85 Compare January 30, 2020 10:04
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #2618 into master will decrease coverage by 0.19%.
The diff coverage is 42.16%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2618     +/-   ##
========================================
- Coverage    63.2%     63%   -0.2%     
========================================
  Files         360     360             
  Lines       33972   34046     +74     
========================================
- Hits        21471   21451     -20     
- Misses       9859    9923     +64     
- Partials     2642    2672     +30
Impacted Files Coverage Δ
go/worker/storage/worker.go 74.26% <ø> (ø) ⬆️
go/registry/api/runtime.go 37.5% <ø> (ø) ⬆️
go/storage/api/api.go 73.91% <ø> (ø) ⬆️
go/registry/api/api.go 36.7% <0%> (-1.2%) ⬇️
go/oasis-test-runner/oasis/runtime.go 0% <0%> (ø) ⬆️
go/oasis-node/cmd/registry/runtime/runtime.go 57.87% <100%> (+1.39%) ⬆️
go/registry/tests/tester.go 90.17% <100%> (+0.07%) ⬆️
go/worker/storage/service_external.go 40.44% <29.41%> (-17.74%) ⬇️
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0%> (-16.37%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b63486...e563f39. Read the comment docs.

@kostko kostko marked this pull request as ready for review January 30, 2020 10:21
@Yawning
Copy link
Contributor

Yawning commented Jan 30, 2020

Errr, don't these need to be consensus backed?

@kostko
Copy link
Member Author

kostko commented Jan 30, 2020

Errr, don't these need to be consensus backed?

Hm, good point, once we have storage availability probes they should probably take these into account. I'll move them over to the runtime's storage config.

@kostko kostko force-pushed the kostko/feature/storage-limits branch 2 times, most recently from 2226722 to 677f73e Compare January 30, 2020 15:51
@kostko
Copy link
Member Author

kostko commented Jan 30, 2020

Changed to consensus parameters.

@kostko kostko force-pushed the kostko/feature/storage-limits branch 5 times, most recently from ebd90d0 to 514218c Compare January 30, 2020 20:40
@kostko kostko force-pushed the kostko/feature/storage-limits branch from 514218c to e563f39 Compare January 30, 2020 21:08
@kostko kostko merged commit b3ee039 into master Jan 30, 2020
@kostko kostko deleted the kostko/feature/storage-limits branch January 30, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce limits for storage operations
2 participants