cmd/signer: Add extract command, add entity signer pk check #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yan
force-pushed
the
david-yan/2609
branch
from
26a612e to
9a1230b
Compare
ravenac95
reviewed
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
=======================================
Coverage 63.09% 63.09%
=======================================
Files 360 360
Lines 34075 34075
=======================================
Hits 21499 21499
Misses 9918 9918
Partials 2658 2658Continue to review full report at Codecov.
|
david-yan
force-pushed
the
david-yan/2609
branch
from
8007737 to
6a7b7f0
Compare
kostko
reviewed
Jan 29, 2020
david-yan
force-pushed
the
david-yan/2609
branch
from
87d34ce to
5ac2dd5
Compare
kostko
reviewed
Jan 30, 2020
There was a problem hiding this comment.
Some minor nits, otherwise looks good. Please don't forget to squash the commits and fix the commit message (e.g., do not just use a concatenation of all commit messages as the final message). It should be something like what is in the PR title.
Then it should be good to merge.
david-yan
force-pushed
the
david-yan/2609
branch
from
2ba7506 to
fd5629c
Compare
|
@kostko should all be done. Sorry for not squashing the commit message properly in my previous PR. |
david-yan
force-pushed
the
david-yan/2609
branch
from
fd5629c to
64c8379
Compare
david-yan
force-pushed
the
david-yan/2609
branch
from
64c8379 to
971af2c
Compare
kostko
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2609
oasis-node signer extractcommandentity.Load