registry: bug fixes #2600
Merged
registry: bug fixes #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is breaking as the old certificates are no longer supported, and they must be regenerated. Note that this uses the slower runtime library ed25519 implementation instead of ours due to runtime library limitations.
Yawning
added
p:0
kostko
approved these changes
Jan 27, 2020
To ensure that nodes demonstrate proof that they posess the private keys for all public keys contained in their descriptor, node descriptors now must be signed by the node, consensus, p2p and TLS certificate key. Note: Node descriptors generated prior to this change are now invalid and will be rejected.
Yawning
force-pushed
the
yawning/fix/sigset
branch
from
2e7209b to
c497227
Compare
ptrus
reviewed
Jan 27, 2020
ptrus
reviewed
Jan 27, 2020
Yawning
force-pushed
the
yawning/fix/sigset
branch
from
c497227 to
351983a
Compare
ptrus
approved these changes
Jan 27, 2020
The dump/restore process requires this to be permitted as expired registrations are persisted through an entity's debonding period.
Yawning
force-pushed
the
yawning/fix/sigset
branch
from
351983a to
cab8294
Compare
Codecov Report
@@ Coverage Diff @@
## master #2600 +/- ##
==========================================
+ Coverage 63.28% 63.41% +0.12%
==========================================
Files 357 357
Lines 33474 33671 +197
==========================================
+ Hits 21185 21353 +168
- Misses 9689 9711 +22
- Partials 2600 2607 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2058
Fixes #2598
Fixes #2599