Makefile: Add tag-next-release target #2550
Conversation
tjanez
requested review from
kostko,
peterjgilbert and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2550 +/- ##
==========================================
- Coverage 67.04% 66.91% -0.13%
==========================================
Files 328 328
Lines 30262 30262
==========================================
- Hits 20289 20250 -39
- Misses 7448 7483 +35
- Partials 2525 2529 +4
Continue to review full report at Codecov.
|
| @@ -1 +0,0 @@ | |||
| runtime: Extract common sealing code. | |||
There was a problem hiding this comment.
Was this forgotten? How did that happen?
There was a problem hiding this comment.
So, I ran make changelog on the master branch before #2537 was merged and submitted the Change Log for 20.0 PR (#2540).
Since #2537 was merged before the Change Log PR and I saw that the change was trivial, i.e. it didn't impact the Change Log, I just rebased my PR on top of it. But this then didn't delete the 2537.trivial.md fragment 🙂.
| tag-next-release: | ||
| @$(ENSURE_NEXT_VERSION) | ||
| @$(ECHO_STDERR) "Checking if we can tag version $(NEXT_VERSION) as the next release..." | ||
| @$(ENSURE_NO_CHANGELOG_FRAGMENTS) |
There was a problem hiding this comment.
Ah probably it was due to this missing check :-)
There was a problem hiding this comment.
Yes, this check will ensure this can't happen in the future 🙂.
It was mistakenly left in when preparing the Change Log for release 20.0: #2540.
Add a bunch of helpers to common.mk to allow re-use. Refactor changelog target to use the new helpers.
This should make it easier to test the release tooling without affecting the real releases.
tjanez
force-pushed
the
tjanez/make-tag-next-release
branch
from
b1cd0a3 to
63f7cb9
Compare
Closes: #2458.