Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More release automation #2532

Merged
merged 2 commits into from
Jan 9, 2020
Merged

More release automation #2532

merged 2 commits into from
Jan 9, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jan 9, 2020

Closes #2523. Closes #2512.

Note, documentation on installing the Punch utility for computing the next version will come as part of #2457.

Verified

This commit was signed with the committer’s verified signature.
tjanez Tadej Janež

Verified

This commit was signed with the committer’s verified signature.
tjanez Tadej Janež
@tjanez tjanez force-pushed the tjanez/auto-version branch from 6c79583 to 0cb48ed Compare January 9, 2020 17:23
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to start a doc with how to install all the new Python dependencies for handling releases :-)

Edit: I see you mentioned this is coming 👍

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #2532 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
- Coverage   67.13%   67.06%   -0.08%     
==========================================
  Files         328      328              
  Lines       30119    30119              
==========================================
- Hits        20221    20199      -22     
- Misses       7394     7397       +3     
- Partials     2504     2523      +19
Impacted Files Coverage Δ
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0%> (-16.37%) ⬇️
go/worker/storage/service_external.go 47.61% <0%> (-9.53%) ⬇️
go/worker/storage/committee/node.go 74.86% <0%> (-4.15%) ⬇️
go/storage/mkvs/urkel/syncer/proof.go 84.61% <0%> (-3.85%) ⬇️
go/storage/mkvs/urkel/prefetch.go 59.32% <0%> (-3.39%) ⬇️
go/storage/metrics.go 70.53% <0%> (-2.68%) ⬇️
go/storage/api/grpc.go 67.57% <0%> (-2.29%) ⬇️
go/storage/client/client.go 75.92% <0%> (-1.86%) ⬇️
go/storage/mkvs/urkel/iterator.go 83.76% <0%> (-1.3%) ⬇️
go/runtime/transaction/transaction.go 76.82% <0%> (-1.22%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397353d...0cb48ed. Read the comment docs.

@tjanez tjanez merged commit 05adb32 into master Jan 9, 2020
@tjanez tjanez deleted the tjanez/auto-version branch January 9, 2020 19:44
# - Passing current version as an CLI parameter.
# - Outputting the new version to stdout without making modifications to any
# files.
_PUNCH_VERSION_FILE := $(shell mktemp /tmp/oasis-core.XXXXX.py)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this one lazy too

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also is there any way to clean this up after we're done with it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've implemented both in #2559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automaticaly compute next version of Oasis Core Add changelog Make target to simplify release process
3 participants