Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go staking: add isTransferPermitted tests #2503

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Dec 23, 2019

it was desired that we have tests for this transfer permissions engine

@pro-wh pro-wh added c:consensus/cometbft Category: CometBFT c:staking Category: staking labels Dec 23, 2019
@pro-wh pro-wh requested a review from peterjgilbert December 23, 2019 19:42
@pro-wh pro-wh force-pushed the pro-wh/feature/xferwl branch from e33ceb5 to 04b49c6 Compare December 23, 2019 19:50
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #2503 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2503      +/-   ##
==========================================
+ Coverage   67.02%   67.12%   +0.09%     
==========================================
  Files         324      324              
  Lines       29887    29887              
==========================================
+ Hits        20033    20061      +28     
+ Misses       7377     7351      -26     
+ Partials     2477     2475       -2
Impacted Files Coverage Δ
go/worker/storage/service_external.go 57.14% <0%> (-6.35%) ⬇️
go/common/cbor/codec.go 64.7% <0%> (-5.89%) ⬇️
go/worker/common/p2p/p2p.go 65.31% <0%> (-3.16%) ⬇️
go/roothash/api/commitment/pool.go 70.5% <0%> (-0.59%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (ø) ⬆️
go/consensus/tendermint/tendermint.go 63.07% <0%> (ø) ⬆️
go/worker/merge/committee/node.go 75.36% <0%> (ø) ⬆️
go/consensus/tendermint/abci/mux.go 68.11% <0%> (+0.72%) ⬆️
go/worker/common/committee/group.go 81.78% <0%> (+0.74%) ⬆️
go/storage/api/grpc.go 69.86% <0%> (+1.36%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c878579...04b49c6. Read the comment docs.

@pro-wh pro-wh merged commit b4d818b into master Dec 23, 2019
@pro-wh pro-wh deleted the pro-wh/feature/xferwl branch December 23, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:consensus/cometbft Category: CometBFT c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants